Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errorprone rules and fix some warning #499

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Oct 1, 2024

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 1, 2024
@ebyhr ebyhr changed the title Update errorproner rules and fix some warning Update errorprone rules and fix some warning Oct 1, 2024
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good .. just not sure about RequestBody.create .. without dependency changes .. was that a bug before or is it now? Or neither.

@ebyhr ebyhr merged commit 2775b1d into trinodb:main Oct 1, 2024
3 checks passed
@ebyhr ebyhr deleted the ebi/warning branch October 1, 2024 23:20
@github-actions github-actions bot added this to the 12 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants