Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_separate_group.db_secret #231

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vladimir4862
Copy link

Hello!
I'm not very experienced with Trino configuration, but I do have a bit more experience with Helm charts.
The main question in this PR is determining the correct place to change the file.password-file and file.group-file configurations.

I placed them in a separate folder to keep automatic updates when k8s secrets are updated.
This approach contrasts with using subPath, which does not support automatic file updates within pod volumes.

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2024
@vladimir4862
Copy link
Author

I was inspired by the #188
So maybe @robertpikmets also whant to look at this.

Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it needs a test. Look at test.sh and add a new test case with a separate values file. Thanks for working on this!

charts/trino/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/trino/templates/configmap-coordinator.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants