Memory-aware autoscaling for worker nodes #219
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -20,6 +20,12 @@ spec: | |||
| target: | |||
| type: Utilization | |||
| averageUtilization: {{ .Values.server.autoscaling.targetCPUUtilizationPercentage }} | |||
| - type: Resource | |||
There was a problem hiding this comment.
Should this be wrapped in a conditional block, and .Values.server.autoscaling.targetCPUUtilizationPercentage not have a default? I'm wondering if memory based scaling always makes sense - is any Trino cluster able to utilize more memory, or it depends on the datasources, stats, data skew, etc.
Added support in autoscaling worker nodes according to memory utilization metric.