Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming conflicts and tags #274

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

o0th
Copy link

@o0th o0th commented Feb 7, 2024

This PR fix:

@Nathan-ma
Copy link

Thank you! this fixes it all.

dgiunta added a commit to dgiunta/tpm that referenced this pull request Jun 11, 2024
cd "$(tpm_path)" &&
GIT_TERMINAL_PROMPT=0 git clone -b "$branch" --single-branch --recursive "$plugin" >/dev/null 2>&1
GIT_TERMINAL_PROMPT=0 git clone $branch --single-branch --recursive "https://git::@github.com/$plugin" $plugin >/dev/null 2>&1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be misreading this but does this not break the case where the plugin URL is intended to use SSH? i.e. [email protected]:user/plugin, and [email protected]:user/plugin, effectively removing SSH support for non-GitHub sources?

@@ -82,10 +82,11 @@ tpm_plugins_list_helper() {
# 2. "user/plugin_name"
plugin_name_helper() {
local plugin="$1"
# get only the part after the last slash, e.g. "plugin_name.git"
local plugin_basename="$(basename "$plugin")"
# get only the last part

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This comment provides less context than the original, I think remove it, since the comment for the function is doing the same job.

@ch3st3r08
Copy link

Is there any plans on merging this PR?.

@RossBarnie
Copy link

@ch3st3r08 There's very little activity in this repo these days so don't expect it to be merged any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants