Update API with per provider opts: #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 62.03% 61.82% -0.22%
==========================================
Files 4 4
Lines 353 351 -2
==========================================
- Hits 219 217 -2
Misses 100 100
Partials 34 34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hey Fellas, @chrisdoherty4 , @joelrebel , @pokearu . When you have some cycles, I'd appreciate a review. Please and thank you! |
This enables customization per provider. For example, redfish port, ipmitool cipher suite. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
provider-opts
branch
from
ea9317b
to
c23c9a4
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
The way the linter was run the exit code was being swallowed up and always return 0. This meant that even with linting issues could CI was passing. This fixes that. The new version of the linter found some unused functions, so they were removed. The other changes were to resolve linting issues that were found. Signed-off-by: Jacob Weinstock <[email protected]>
api/v1alpha1/provider_opts.go
Outdated
| // PrefixSigDisabled determines whether the algorithm will be prefixed to the signature. Example: sha256=abc123 | ||
| PrefixSigDisabled bool `json:"prefixSigDisabled"` | ||
| // Secrets are a map of algorithms to secrets used for signing. | ||
| Secrets RPCSecrets `json:"secrets"` |
There was a problem hiding this comment.
Might consider HMACSecrets
Signed-off-by: Jacob Weinstock <[email protected]>
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 357b551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables customization per provider. For example, redfish port, ipmitool cipher suite.
Why is this needed
Once implemented will resolve #89 and #103
Fixes:
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: