Add login page #1

subinasr · 2023-06-12T09:38:34Z

No description provided.

- Add submodule

AdityaKhatri · 2023-07-12T04:44:07Z

index.html

+        <link rel="preconnect" href="https://fonts.googleapis.com">
+        <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
+        <link
+            href="https://fonts.googleapis.com/css2?family=Source+Sans+3:wght@300;400;700;900;&display=swap"
+            rel="stylesheet"
+        >


add trailing slack if necessary

Do you mean trailing slash? If yes, it's not required here.

AdityaKhatri · 2023-07-12T04:45:50Z

src/App/routes.tsx

+
+const login = myWrapRoute({
+    title: 'Login',
+    path: 'login',


Suggested change

path: 'login',

path: '/login',

Not required here, either.

AdityaKhatri · 2023-07-12T04:46:16Z

src/components/FullPageErrorMessage/index.module.css

+        text-align: center;
+
+        .logo {
+            width: 450px;


define in rem

AdityaKhatri · 2023-07-12T04:47:19Z

src/components/HCaptcha/index.tsx

+            input={siteKey && (
+                <HCaptcha
+                    ref={elementRef}
+                    // disabled={disabled || readOnly}


Double-check if disabled is required or not.

AdityaKhatri · 2023-07-12T04:48:16Z

src/configs/hCaptcha.ts

+import {
+    hCaptchaKey as hCaptchaKeyFromEnv,
+} from './env.ts';
+
+// eslint-disable-next-line import/prefer-default-export
+export const hCaptchaKey = hCaptchaKeyFromEnv;


Lets remove this file and direcly use the key in hCaptcha file

AdityaKhatri · 2023-07-12T04:52:23Z

src/views/Register/index.tsx

+
+import styles from './index.module.css';
+
+// FIXME: import is weird will full names


Which import?

AdityaKhatri · 2023-07-12T04:53:29Z

src/views/ResetPassword/index.tsx

+                }
+                if (response.ok) {
+                    alert.show(
+                        'Logged in successfully!',


Suggested change

'Logged in successfully!',

'Password reset successfully!',

AdityaKhatri · 2023-07-12T04:53:54Z

src/views/ResetPassword/index.tsx

+                    type="submit"
+                    disabled={pristine || resetPasswordPending}
+                    onClick={handleSubmit}
+                    // FIXME: disable button when submitting


I think this is already done

AdityaKhatri · 2023-07-12T04:54:03Z

src/views/ResetPassword/index.tsx

+                    name="captcha"
+                    elementRef={elementRef}
+                    siteKey={hCaptchaKey}
+                    // value={value.captcha}


This should be present

AdityaKhatri · 2023-07-12T04:54:22Z

src/views/ResetPassword/index.tsx

+                    alert.show(
+                        'Logged in successfully!',
+                        { variant: 'success' },
+                    );


We need to redirect the user to login page after password is reset.

AdityaKhatri · 2023-07-20T08:30:16Z

src/App/routes.tsx

+    },
+});
+
+// FIXME: eager load this page


remove fixme

AdityaKhatri · 2023-07-20T08:31:30Z

src/redirects/ResetPasswordRedirect.tsx

+    useParams,
+} from 'react-router-dom';
+
+// import { wrappedRoutes } from '../App/routes.tsx';


remove if not used

AdityaKhatri · 2023-07-20T08:31:54Z

src/utils/localStorage.ts

@@ -0,0 +1,12 @@
+export function getFromStorage<T>(key: string) {


I don't this is required any longer.

Add login page

3160579

subinasr requested a review from AdityaKhatri June 12, 2023 09:38

subinasr added 3 commits June 12, 2023 16:27

Add backend submodule

61e85a0

Add register form

5708f1c

Add graphql and codegen configs

05232c1

subinasr marked this pull request as ready for review June 16, 2023 08:02

subinasr assigned AdityaKhatri Jun 16, 2023

subinasr force-pushed the feature/login-page branch 2 times, most recently from 926b4cd to 1fb556d Compare June 16, 2023 08:06

Add register form and mutation

9a40ddb

subinasr force-pushed the feature/login-page branch from 1fb556d to 9a40ddb Compare June 16, 2023 08:15

Fix type and lint fixes

f17c682

subinasr force-pushed the feature/login-page branch from ea31528 to b7f53ac Compare July 4, 2023 06:30

Initialize generated files

68bdff9

subinasr force-pushed the feature/login-page branch from b7f53ac to 68bdff9 Compare July 4, 2023 06:38

Fix CI

916f514

subinasr force-pushed the feature/login-page branch from 1de368c to 916f514 Compare July 11, 2023 09:43

Use checkout for submodules

99047e9

subinasr force-pushed the feature/login-page branch 4 times, most recently from a512e88 to 4e35589 Compare July 11, 2023 11:02

subinasr had a problem deploying to Test July 11, 2023 11:02 — with GitHub Actions Failure

subinasr force-pushed the feature/login-page branch from 4e35589 to e7a87a8 Compare July 11, 2023 11:04

subinasr temporarily deployed to Test July 11, 2023 11:05 — with GitHub Actions Inactive

subinasr temporarily deployed to Test July 11, 2023 11:07 — with GitHub Actions Inactive

subinasr temporarily deployed to Test July 11, 2023 11:09 — with GitHub Actions Inactive

subinasr temporarily deployed to Test July 11, 2023 11:10 — with GitHub Actions Inactive

subinasr temporarily deployed to Test July 11, 2023 11:15 — with GitHub Actions Inactive

subinasr force-pushed the feature/login-page branch from e7a87a8 to bb13b83 Compare July 11, 2023 11:20

subinasr had a problem deploying to Test July 11, 2023 11:42 — with GitHub Actions Failure

subinasr force-pushed the feature/login-page branch from bb13b83 to 4212ec4 Compare July 11, 2023 11:45

subinasr temporarily deployed to Test July 11, 2023 11:45 — with GitHub Actions Inactive

Fix CI

608348f

- Add submodule

subinasr force-pushed the feature/login-page branch from 4212ec4 to 608348f Compare July 12, 2023 04:06

subinasr temporarily deployed to Test July 12, 2023 04:06 — with GitHub Actions Inactive

subinasr temporarily deployed to Test July 12, 2023 04:21 — with GitHub Actions Inactive

subinasr had a problem deploying to Test July 12, 2023 04:23 — with GitHub Actions Failure

subinasr temporarily deployed to Test July 12, 2023 04:39 — with GitHub Actions Inactive

AdityaKhatri requested changes Jul 12, 2023

View reviewed changes

Fetch and list projects in home page

ba375ba

subinasr had a problem deploying to Test July 19, 2023 08:35 — with GitHub Actions Failure

subinasr temporarily deployed to Test July 19, 2023 13:01 — with GitHub Actions Inactive

Add logout

848c9cb

subinasr force-pushed the feature/login-page branch from 697b1c5 to 848c9cb Compare July 20, 2023 04:27

subinasr had a problem deploying to Test July 20, 2023 04:27 — with GitHub Actions Failure

AdityaKhatri requested changes Jul 20, 2023

View reviewed changes

subinasr temporarily deployed to Test July 20, 2023 09:22 — with GitHub Actions Inactive

subinasr force-pushed the feature/login-page branch from 454f1b8 to 839d54d Compare July 20, 2023 09:37

subinasr temporarily deployed to Test July 20, 2023 09:38 — with GitHub Actions Inactive

subinasr force-pushed the feature/login-page branch from 839d54d to b58c8e6 Compare July 20, 2023 09:42

subinasr temporarily deployed to Test July 20, 2023 09:42 — with GitHub Actions Inactive

Fix stylings

f418d78

subinasr force-pushed the feature/login-page branch from b58c8e6 to f418d78 Compare July 20, 2023 12:12

subinasr temporarily deployed to Test July 20, 2023 12:12 — with GitHub Actions Inactive

subinasr had a problem deploying to Test July 20, 2023 12:14 — with GitHub Actions Failure

AdityaKhatri approved these changes Aug 1, 2023

View reviewed changes

AdityaKhatri merged commit 46a20e8 into develop Aug 1, 2023
6 of 7 checks passed

AdityaKhatri deleted the feature/login-page branch August 1, 2023 02:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add login page #1

Add login page #1

subinasr commented Jun 12, 2023

AdityaKhatri Jul 12, 2023

subinasr Jul 13, 2023

AdityaKhatri Jul 12, 2023

subinasr Jul 13, 2023

AdityaKhatri Jul 12, 2023

AdityaKhatri Jul 12, 2023

AdityaKhatri Jul 12, 2023

AdityaKhatri Jul 12, 2023

AdityaKhatri Jul 12, 2023

AdityaKhatri Jul 12, 2023

AdityaKhatri Jul 12, 2023

AdityaKhatri Jul 12, 2023

AdityaKhatri Jul 20, 2023

AdityaKhatri Jul 20, 2023

AdityaKhatri Jul 20, 2023


		import styles from './index.module.css';

		// FIXME: import is weird will full names

		@@ -0,0 +1,12 @@
		export function getFromStorage<T>(key: string) {

Add login page #1

Add login page #1

Conversation

subinasr commented Jun 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment