Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use <module source> specifier #4194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use <module source> specifier #4194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions test/language/module-code/source-phase-import/import-source-binding-name-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,9 @@ info: |
ImportDeclaration:
import source ImportedBinding FromClause ;

negative:
phase: resolution
type: SyntaxError
features: [source-phase-imports]
features: [source-phase-imports, source-phase-imports-module-source]
flags: [module]
---*/

$DONOTEVALUATE();

import "../resources/ensure-linking-error_FIXTURE.js";

import source source from '<do not resolve>';
import source from from '<do not resolve>';
import source source from '<module source>';
import source from from '<module source>';
13 changes: 3 additions & 10 deletions test/language/module-code/source-phase-import/import-source-binding-name.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,9 @@ info: |
ImportDeclaration:
import source ImportedBinding FromClause ;

negative:
phase: resolution
type: SyntaxError
features: [source-phase-imports]
features: [source-phase-imports, source-phase-imports-module-source]
flags: [module]
---*/

$DONOTEVALUATE();

import "../resources/ensure-linking-error_FIXTURE.js";

import source from '<do not resolve>';
import from from '<do not resolve>';
import source from '<module source>';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid using <module source> in non-source imports.

import from from '<module source>';
12 changes: 3 additions & 9 deletions test/language/module-code/source-phase-import/import-source-newlines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,13 @@ info: |

16.2.1.7.2 GetModuleSource ( )
Source Text Module Record provides a GetModuleSource implementation that always returns an abrupt completion indicating that a source phase import is not available.
negative:
phase: resolution
type: SyntaxError
features: [source-phase-imports]

features: [source-phase-imports, source-phase-imports-module-source]
flags: [module]
---*/

$DONOTEVALUATE();

import "../resources/ensure-linking-error_FIXTURE.js";

import



source



y from '<do not resolve>';


y from '<module source>';
Loading