Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGN-441 - Only fetch useTrade when neccessary #974

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

chillichelli
Copy link
Contributor

@chillichelli chillichelli commented Jun 28, 2023

PR-Codex overview

Detailed summary

  • The enabled prop is added to the useTrade hook in TradeReviewDialog.tsx, TradeReviewDialogCrossChain.tsx, TradeReviewDialogSameChain.tsx, ConfirmationDialog.tsx, and useTrade.ts.
  • The enabled prop is used to determine if the trade should be enabled or not.
  • The enabled prop is set to true by default.
  • The enabled prop is set to false in TradeReviewDialog.tsx and TradeReviewDialogSameChain.tsx when review is false.
  • The enabled prop is set to false in useTrade.ts when crossChain is true and network0 and network1 are not SushiXSwap chain IDs.
  • The enabled prop is set to false in useTrade.ts when crossChain is false and network0 and network1 are not the same or isFallback is true.
  • The enabled prop is set to false in useTrade.ts when crossChain is false and network0 and network1 are the same and isFallback is true, but value is not truthy.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jun 28, 2023

EGN-441 Reduce RPC calls

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

⚠️ No Changeset found

Latest commit: fb93b43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
analytics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
balances ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
earn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
furo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
pools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
root 🔄 Building (Inspect) Jun 28, 2023 10:33pm
token-list ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
token-price ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm
tokens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 10:33pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants