Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent duplicate logs #559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent duplicate logs #559

wants to merge 1 commit into from
+19 −13

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Sep 30, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

This PR fixes the edge case where aborted request prints logs twice

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11110115794

Details

  • 11 of 19 (57.89%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 78.551%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/plugins/log-request.ts 6 8 75.0%
src/http/plugins/signals.ts 5 11 45.45%
Files with Coverage Reduction New Missed Lines %
src/http/plugins/signals.ts 2 84.13%
src/http/plugins/log-request.ts 5 90.18%
Totals Coverage Status
Change from base Build 11106554547: -0.09%
Covered Lines: 13713
Relevant Lines: 17313
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcnc pcnc pcnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fenos @coveralls @pcnc