Bugfix/#133 special characters in filename #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
major-winter
force-pushed
the
bugfix/#133_special_characters_in_filename
branch
from
ece1933
to
adf5767
Compare
- Modify the method isValidKey to allow special characters - Create a new unit test that verifies special characters are now allowed as object key
major-winter
force-pushed
the
bugfix/#133_special_characters_in_filename
branch
from
adf5767
to
f616e44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
This fix addresses the issue described in this bug item
What is the new behavior?
Allowing special characters to be used as object key