Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable security opts for db test on bitbucket runner #2705

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

avallete
Copy link
Contributor

What kind of change does this PR introduce?

Skip unsupported SecurityOpt on bitbucket runners.

Fixes #2703

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Tested with the setup-cli on bitbucket platform using the current branch.

@avallete avallete requested a review from a team as a code owner September 24, 2024 09:38
@coveralls
Copy link

coveralls commented Sep 24, 2024

Pull Request Test Coverage Report for Build 11011131958

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 60.028%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/docker.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11010806877: -0.05%
Covered Lines: 6456
Relevant Lines: 10755

💛 - Coveralls

@sweatybridge sweatybridge changed the title hotfix(cli): disable security opts for db test on bitbucket runner fix(cli): disable security opts for db test on bitbucket runner Sep 24, 2024
@sweatybridge sweatybridge changed the title fix(cli): disable security opts for db test on bitbucket runner fix: disable security opts for db test on bitbucket runner Sep 24, 2024
@sweatybridge sweatybridge merged commit 11c5004 into develop Sep 24, 2024
12 checks passed
@sweatybridge sweatybridge deleted the avallete/hotfix-bitbucket-db-test branch September 24, 2024 10:05
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db test fails on Bitbucket CI with cli release v1.200.3
3 participants