Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip]: feat load env for any variables #2700

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

avallete
Copy link
Contributor

What kind of change does this PR introduce?

Attempt to re-use similar logic as in LoadRemoteConfigOverrides to unify the "env variables" loading logic across all the config.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10959929592

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 60.041%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/config.go 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
internal/utils/config.go 9 84.16%
Totals Coverage Status
Change from base Build 10919817737: -0.1%
Covered Lines: 6449
Relevant Lines: 10741

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants