Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows env var to override linked project id #2480

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jul 2, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Setting SUPABASE_PROJECT_ID env var should override any linked project.

Additional context

Blocked on further testing.

@sweatybridge sweatybridge requested a review from a team as a code owner July 2, 2024 08:56
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9757976962

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 61.383%

Files with Coverage Reduction New Missed Lines %
internal/utils/flags/project_ref.go 1 85.71%
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 9754745155: -0.03%
Covered Lines: 7021
Relevant Lines: 11438

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9758923763

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 61.192%

Files with Coverage Reduction New Missed Lines %
internal/utils/flags/project_ref.go 1 85.71%
Totals Coverage Status
Change from base Build 9757998779: 0.0%
Covered Lines: 7053
Relevant Lines: 11526

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants