Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply authorized email restriction to non-admin routes #1778

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Sep 27, 2024

What kind of change does this PR introduce?

  • Move the email restriction validation to the middleware rather than doing it in the validateEmail function
  • Excludes requests made to the /admin endpoints and any GET and DELETE requests

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@kangmingtay kangmingtay requested a review from a team as a code owner September 27, 2024 17:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11076162407

Details

  • 30 of 30 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 57.966%

Totals Coverage Status
Change from base Build 11048263084: 0.05%
Covered Lines: 9351
Relevant Lines: 16132

💛 - Coveralls

@kangmingtay kangmingtay merged commit 1af203f into master Sep 27, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/fix-authorized-emails branch September 27, 2024 19:01
kangmingtay pushed a commit that referenced this pull request Sep 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.162.0](v2.161.0...v2.162.0)
(2024-09-27)


### Features

* add support for migration of firebase scrypt passwords
([#1768](#1768))
([ba00f75](ba00f75))


### Bug Fixes

* apply authorized email restriction to non-admin routes
([#1778](#1778))
([1af203f](1af203f))
* magiclink failing due to passwordStrength check
([#1769](#1769))
([7a5411f](7a5411f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants