feat: add MFA for WebAuthn #1775
Draft
+735
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
commented
Sep 27, 2024
example.env
Outdated
| @@ -233,3 +233,6 @@ GOTRUE_HOOK_CUSTOM_SMS_PROVIDER_SECRET="" | |||
| # Test OTP Config | |||
J0
commented
Sep 28, 2024
| @@ -0,0 +1,2 @@ | |||
| alter table {{ index .Options "Namespace" }}.mfa_factors add column if not exists web_authn_credential jsonb null; | |||
J0
commented
Sep 28, 2024
| } | ||
| for _, factor := range user.Factors { | ||
| switch { | ||
| case factor.FriendlyName == params.FriendlyName: |
There was a problem hiding this comment.
Validation checks can be condensed into a single function. Work for that is done here: #1780
|
Not quite ready yet, please check back after 12pm CEST tomorrow.. |
hf
reviewed
Sep 30, 2024
Pull Request Test Coverage Report for Build 11113961168Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds MFA for WebAuthn
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.