Update identities email_verified on email signup #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the same is happening for smsVerify and the respective phone_verified fields, do you want me to add this to this PR? |
|
Feel free to add it, will give a thorough look to the PR when a slot frees up.. |
Pull Request Test Coverage Report for Build 9510681514Details
💛 - Coveralls |
alex-guoba
reviewed
Jun 19, 2024
alex-guoba
reviewed
Jul 2, 2024
| @@ -335,6 +335,18 @@ func (a *API) signupVerify(r *http.Request, ctx context.Context, conn *storage.C | |||
| if terr = user.Confirm(tx); terr != nil { | |||
| return internalServerError("Error confirming user").WithInternalError(terr) | |||
| } | |||
|
|
|||
| if identity, terr := models.FindIdentityByIdAndProvider(tx, user.ID.String(), "email"); terr != nil { | |||
| if !models.IsNotFoundError(terr) { | |||
There was a problem hiding this comment.
why skip IsNotFoundError? in Signup flow, user and identity will be both inserted, identity record should be found here.
|
Hi, Face this issue while working with Supabase auth. Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR fixes a bug where the email_verified field in the identities table is not updated when a user's email is confirmed. This change ensures that the email verification status is correctly reflected in the JWT.
What is the current behavior?
When the user gets an email confirmation link the GET /verify request is called. This goes through the verifyGet method which then calls the signupVerify method. There the AuditLogEntry is created, then the Confirm method on the user is called which updates the
confirmation_tokenandemail_confirmed_at, and also clears the OneTimeTokens for the user. However, theemail_confirmedfield on the identities table does not get updated to true.#1620
What is the new behavior?
When a GET /verify request is called for a mail signup verification, the signupVerify method now updates the
email_verifiedproperty to true on theidentity_datafield on theidentitiestable