fix: update mfa provider

supabase · Sep 30, 2024 · c112b4b · c112b4b
1 parent 0ca3f7d
commit c112b4b
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 2 deletions.
diff --git a/internal/api/mfa.go b/internal/api/mfa.go
@@ -592,10 +592,9 @@ func (a *API) verifyPhoneFactor(w http.ResponseWriter, r *http.Request, params *
 	var valid bool
 	var otpCode string
 	var shouldReEncrypt bool
-	var err error
 	if config.Sms.IsTwilioVerifyProvider() {
 		smsProvider, _ := sms_provider.GetSmsProvider(*config)
-		if err := smsProvider.(*sms_provider.TwilioVerifyProvider).VerifyOTP(factor.Phone.String(), nonce); err != nil {
+		if err := smsProvider.VerifyOTP(factor.Phone.String(), params.Code); err != nil {
 			return forbiddenError(ErrorCodeOTPExpired, "Token has expired or is invalid").WithInternalError(err)
 		}
 		valid = true

diff --git a/internal/api/sms_provider/messagebird.go b/internal/api/sms_provider/messagebird.go
@@ -109,3 +109,7 @@ func (t *MessagebirdProvider) SendSms(phone string, message string) (string, err
 
 	return resp.ID, nil
 }
+
+func (t *MessagebirdProvider) VerifyOTP(phone, code string) error {
+	return fmt.Errorf("VerifyOTP is not supported for Messagebird")
+}
diff --git a/internal/api/sms_provider/sms_provider.go b/internal/api/sms_provider/sms_provider.go
@@ -30,6 +30,7 @@ func init() {
 
 type SmsProvider interface {
 	SendMessage(phone, message, channel, otp string) (string, error)
+	VerifyOTP(phone, token string) error
 }
 
 func GetSmsProvider(config conf.GlobalConfiguration) (SmsProvider, error) {

diff --git a/internal/api/sms_provider/textlocal.go b/internal/api/sms_provider/textlocal.go
@@ -102,3 +102,6 @@ func (t *TextlocalProvider) SendSms(phone string, message string) (string, error
 
 	return messageID, nil
 }
+func (t *TextlocalProvider) VerifyOTP(phone, code string) error {
+	return fmt.Errorf("VerifyOTP is not supported for Textlocal")
+}
diff --git a/internal/api/sms_provider/twilio.go b/internal/api/sms_provider/twilio.go
@@ -136,3 +136,6 @@ func (t *TwilioProvider) SendSms(phone, message, channel, otp string) (string, e
 
 	return resp.MessageSID, nil
 }
+func (t *TwilioProvider) VerifyOTP(phone, code string) error {
+	return fmt.Errorf("VerifyOTP is not supported for Twilio")
+}
diff --git a/internal/api/sms_provider/vonage.go b/internal/api/sms_provider/vonage.go
@@ -99,3 +99,7 @@ func (t *VonageProvider) SendSms(phone string, message string) (string, error) {
 
 	return resp.Messages[0].MessageID, nil
 }
+
+func (t *VonageProvider) VerifyOTP(phone, code string) error {
+	return fmt.Errorf("VerifyOTP is not supported for Vonage")
+}