Skip to content

Commit

Permalink
chore(deps): update dependency typescript-eslint to v8.7.0 (#4955)
Browse files Browse the repository at this point in the history
* chore(deps): update dependency typescript-eslint to v8.7.0

* fix lint warnings

* Fix eslint lint

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Nico Jansen <[email protected]>
  • Loading branch information
renovate[bot] and nicojs authored Sep 27, 2024
1 parent 1990a6e commit 8f324a8
Show file tree
Hide file tree
Showing 7 changed files with 58 additions and 58 deletions.
1 change: 0 additions & 1 deletion e2e/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { rules } from '../eslint.config.js';
export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
// @ts-expect-error: Not all properties are typed
eslintPluginPrettierRecommended,
{
languageOptions: {
Expand Down
7 changes: 4 additions & 3 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended'
// @ts-expect-error: No types available
import pluginChaiFriendly from 'eslint-plugin-chai-friendly';

export const rules = Object.freeze({
/** @type {import('@typescript-eslint/utils').TSESLint.FlatConfig.Rules} */
export const rules = {
'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_*', ignoreRestSiblings: true, varsIgnorePattern: '^_' }],

// fix - separate PR
Expand All @@ -22,11 +23,11 @@ export const rules = Object.freeze({

// We don't care
'@typescript-eslint/no-explicit-any': 'off',
});
};

export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
// @ts-expect-error: Not all properties are typed
eslintPluginPrettierRecommended,
{
languageOptions: {
Expand Down
100 changes: 50 additions & 50 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"source-map-support": "0.5.21",
"ts-node": "10.9.2",
"typescript": "5.5.4",
"typescript-eslint": "8.0.1"
"typescript-eslint": "8.7.0"
},
"scripts": {
"all": "npm run clean && npm run build && npm run lint && npm run test",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/helpers/file-system-test-double.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type Param<TMethod extends keyof I<FileSystem>, n extends number> = Parameters<F
export class FileSystemTestDouble implements I<FileSystem> {
public dirs = new Set<string>();
constructor(public readonly files: Record<string, string> = Object.create(null)) {}
public async dispose(): Promise<void> {
public dispose(): void {
// Idle, nothing to do here
}

Expand Down
2 changes: 1 addition & 1 deletion packages/instrumenter/src/parsers/create-parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { ParserOptions } from './parser-options.js';

export function createParser(
parserOptions: ParserOptions,
): <T extends AstFormat = AstFormat>(code: string, fileName: string, formatOverride?: T | undefined) => Promise<AstByFormat[T]> {
): <T extends AstFormat = AstFormat>(code: string, fileName: string, formatOverride?: T) => Promise<AstByFormat[T]> {
const jsParse = createJSParser(parserOptions);
return async function parse<T extends AstFormat = AstFormat>(code: string, fileName: string, formatOverride?: T): Promise<AstByFormat[T]> {
const format = getFormat(fileName, formatOverride);
Expand Down
2 changes: 1 addition & 1 deletion packages/test-helpers/src/logging-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class LoggingServer {
} else {
this.disposed = true;
return new Promise((res, rej) => {
this.server.close((err?: Error | undefined) => {
this.server.close((err?: Error) => {
if (err) {
rej(err);
} else {
Expand Down

0 comments on commit 8f324a8

Please sign in to comment.