Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BANKCON-14534] Add expected_payment_method_type to /confirm params #4077

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mats-stripe
Copy link
Collaborator

Summary

As part of the Panther project, this passes the expected_payment_method_type param to the /confirm payment endpoint after going through the instant debits flow.

Motivation

BANKCON-14534

Testing

E2E tests coming soon. Verified the parameter is passed to the /confirm endpoint:

Screenshot 2024-09-30 at 9 35 14 AM

Changelog

N/a

tillh-stripe
tillh-stripe previously approved these changes Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

🚨 New dead code detected in this PR:

{
  "FinancialConnectionsAPIClient.swift_sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:)": "FinancialConnectionsAPIClient.swift: warning: sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:) is unused",
  "EmptyFinancialConnectionsAPIClient.swift_sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:)": "EmptyFinancialConnectionsAPIClient.swift: warning: sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:) is unused"
}

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

Base automatically changed from mats/call_share_endpoint_for_panther_payments to master September 30, 2024 18:40
@mats-stripe mats-stripe dismissed tillh-stripe’s stale review September 30, 2024 18:40

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants