[SEP-31] Add new user_action_required_by field
#1486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeUrban
reviewed
May 14, 2024
| | `started_at` | UTC ISO 8601 string | (optional) Start date and time of transaction. | | ||
| | `updated_at` | UTC ISO 8601 string | (optional) The date and time of transaction reaching the current `status`. | | ||
| | `completed_at` | UTC ISO 8601 string | (optional) Completion date and time of transaction. | | ||
| | `user_action_required_by` | UTC ISO 8601 string | (optional) The date and time by when the user action is required. In certain statuses, such as `pending_customer_info_update`, anchor waits for the user action and `user_action_required_by` field should be used to show the time anchors gives for the user to make an action before transaction will automatically be moved into a different status (such as `expired` or to be `refunded`). `user_action_required_by` should only be specified for statuses where user action is required, and omitted for all other. Anchor should specify the action waited on using message or `more_info_url`. | |
There was a problem hiding this comment.
SEP-31 involves two users, how should this field be used in this context? For the sender, for both?
There was a problem hiding this comment.
I think we can do it for both users, as it's makes things more simple
|
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New field
user_action_required_bywas added in SEP-24/SEP-6 fields previously in #1484For consistency, this field should be added to SEP-31 as well