Fix MSVS project. #4490
Merged
Fix MSVS project. #4490
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like it's not possible to link the release build of the rust libraries to the debug-mode core, so I'm disabling tracy for the debug builds. Neither debug rust builds, nor tracy in debug mode are useful on Windows builds (FWIW I'm not sure if tracy is usable at all on Windows, but in general profiling shouldn't be normally done on debug builds). There is also a weird issue of `intrin.h` missing when tracy is disabled, so I've added the include explicitly.
sisuresh
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like it's not possible to link the release build of the rust libraries to the debug-mode core, so I'm disabling tracy for the debug builds. Neither debug rust builds, nor tracy in debug mode are useful on Windows builds (FWIW I'm not sure if tracy is usable at all on Windows, but in general profiling shouldn't be normally done on debug builds).
There is also a weird issue of
intrin.hmissing when tracy is disabled, so I've added the include explicitly.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)