Testutils bug(s) #4489
Merged
Testutils bug(s) #4489
+10
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
reviewed
Sep 27, 2024
| @@ -8,12 +8,6 @@ include $(srcdir)/src.mk | |||
|
|
|||
| noinst_HEADERS = $(SRC_H_FILES) | |||
|
|
|||
| if BUILD_TESTS | |||
There was a problem hiding this comment.
Did you mean to remove this block?
There was a problem hiding this comment.
Yes, it was accidental duplication while editing.
sisuresh
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes 3 changes:
--features testutilsto soroban when building withBUILD_TESTSThe key part here is the first; evidently having
testutilsturned on on soroban makes the cost structure observably different and thereby causes divergence during replay. This seems wrong to me, and something we should track down and eliminate, but in the meantime this at least (a) gets rid of that divergence and (b) does what we did before I accidentally started passingtestutilsin the recent soroban-submodule change (#4456)