Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade validation #4485

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix upgrade validation #4485

merged 1 commit into from
Sep 25, 2024
+19 −5

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Sep 25, 2024 •
edited
Loading

Description

Fix the upgrade validation to handle settings upgrades for the previous protocol. Also rewrote the condition so our test cases will catch this issue next time settings are added.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh added this pull request to the merge queue Sep 25, 2024
Merged via the queue into stellar:master with commit 0256109 Sep 25, 2024
13 checks passed
@sisuresh sisuresh deleted the settings-validation branch September 25, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

@marta-lokhova marta-lokhova Awaiting requested review from marta-lokhova

@anupsdf anupsdf Awaiting requested review from anupsdf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisuresh @dmkozh