Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P22 with wasmi reverted to 031 #1460

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Sep 14, 2024

This reverts wasmi from 0.36 to 0.31 while retaining everything else that's happened in p22. In particular the host still only speaks p22 and refuses to emulate p21.

This is just a trial PR in case we have need to back out 0.36 in the p22 timeframe.

@graydon graydon requested review from sisuresh, dmkozh and a team as code owners September 14, 2024 03:43
@dmkozh
Copy link
Contributor

dmkozh commented Sep 16, 2024

Anyway I'm still trying to decide how far to go in trying to "fix" this test. I think the fact that the host fails -- rejects the f32-using code -- is actually a good thing. So I kinda want to just change the test to not-do that, to upload some other actually legal contract. But I'm not sure.

I did a bit of research and figured out that this is fine. In p21 we didn't build module cache for create_contract operation because we didn't instantiate VM. In p22 we do that to support constructors, but the error has been avoided due to lazy Wasmi compilation mode used by the module cache (as opposed to the eager mode on upload). Thus the test failing is expected for the old Wasmi as it doesn't have a lazy mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants