Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Methods: make diagnostic events XDR clickable links #1072

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

quietbits
Copy link
Contributor

@quietbits quietbits commented Sep 30, 2024

@quietbits quietbits linked an issue Sep 30, 2024 that may be closed by this pull request
@stellar-jenkins
Copy link

@janewang
Copy link
Contributor

janewang commented Sep 30, 2024

In the network tab, set mainnet RPC to https://soroban-rpc.mainnet.stellar.gateway.fm.

Go to getLedgerEntries and paste AAAAB7r5ePEO/bzYV0eGi++IMoRepoCfdkO2ekrAzWaTJ/ws into the Ledger Key XDR and click submit. In the response, click on the xdr string and see an error page.

Screen.Recording.2024-09-30.at.2.22.19.PM.mov

I can also replicate the same issue on lab.stellar.org

@quietbits
Copy link
Contributor Author

In the network tab, set mainnet RPC to https://soroban-rpc.mainnet.stellar.gateway.fm.

Go to getLedgerEntries and paste AAAAB7r5ePEO/bzYV0eGi++IMoRepoCfdkO2ekrAzWaTJ/ws into the Ledger Key XDR and click submit. In the response, click on the xdr string and see an error page.

Screen.Recording.2024-09-30.at.2.22.19.PM.mov
I can also replicate the same issue on lab.stellar.org

@janewang I think the issue with that specific XDR is that it's too long for the browser to parse the URL. The XDR is about 67k characters long. I'm not sure how common such large XDRs are or if this is an edge case. I don't think there's anything we can do about that. If you enter that same XDR on the View XDR page and then refresh the page, you'll get the same error.

@quietbits quietbits merged commit 387dd11 into master Sep 30, 2024
3 checks passed
@quietbits quietbits deleted the endpoints-diagnostic-events-xdr-links branch September 30, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Diagnostic events XDR not clickable as links in the response
4 participants