Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs to Developer Documentation #5371

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ElliotFriend
Copy link

@ElliotFriend ElliotFriend commented Jul 3, 2024

The stellar-docs site has undergone some structural updates/changes. Among other areas, the Horizon API documentation has been affected. This PR aims to make current all references to the developers documentation.

There was one series of links I had a particularly hard time with, and would love to have some feedback on. The /services/horizon/internal/actions/submit_transaction_async.go had a bunch of URLs to pages that (I assume) would've included some Async-transaction-submission-specific error codes. Every link that was there gives a 404, and I can't recall ever having seen those async-submission-specific pages. I took a shot at using (guessing, really) the right non-async-specific error pages, but I'm not sure if that's the right move?

Edit: I also tried to test the repo locally, but I was getting a lot of db-related errors, and I couldn't quite figure out which environment variables I did or didn't need

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the async-specific URLs I was having a hard time with.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @urvisavla!! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants