Ransack control params (:m, :s) mangled by translator into :m_, :s_ #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nslator#join_key. Racksack::Predicate returns nil, really any non-value should be handled without mangling arbitrary params used to control ransack. Also took the liberty of removing the skip of the 's' param in key_with_translations, since I am assuming this was inserted for a similar reason. This fix should be more applicable to future control params as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents changing the default grouping of the AND ransack query to OR.
Change uses check blank? instead of == '' for non-values in SpreeI18n::RansackTranslator#join_key. Racksack::Predicate returns nil, really any non-value should be handled without mangling arbitrary params used to control ransack. Also took the liberty of removing the skip of the 's' param in key_with_translations, since I am assuming this was inserted for a similar reason. This fix should be more applicable to future control params as well.