Removed useless setters #552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update tests update xml files for updated tests
hirohitoqwe
changed the title
|
I agree with @hirohitoqwe - changefreq and priority are not commonly used (by Google) but may be by other search engines. Everything I have read still recommends using them "just in case" and as a guide for a bot. Why not keep them in the code? If there's a definitive article stating that they are deprecated across all search engines, please link and I'll happily change my mind :-) |
|
My pull request is open from 9.08.2024 :) Still not reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I recently started using this library and found that the priority and changefreq parameters are deprecated. In this regard, I decided to basically remove them from the code.
To be honest, I don't think it would be right to delete these parameters, because there is not only the Google search engine, perhaps these parameters are still relevant in other search engines. I would be happy if you didn't accept my deletion request and rolled back this one: #545
Thank you.