Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with spatie/crawler 8.0 #520

Closed
wants to merge 5 commits into from

Conversation

thoasty-dev
Copy link

- spatie/laravel-sitemap[6.2.4, ..., 6.3.1] require spatie/crawler ^7.0 -> found spatie/crawler[7.0.0, ..., 7.1.3] but it conflicts with your root composer.json require (^8.0).```

@mikkpokk
Copy link

@freekmurze Would love to see that release. Currently I cannot use the package in my project, which already uses crawler 8.0.1 😞

@thoasty-dev
Copy link
Author

If you really need to, you can use the patch like this with composer in the meantime:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/thoasty-dev/laravel-sitemap.git"
        }
    ],


    "require": {
        "spatie/laravel-sitemap": "dev-patch-1"
    },
}

@freekmurze
Copy link
Member

Seems like the tests are failing, could you take a look?

@thoasty-dev
Copy link
Author

We need to remove ^7.0 from the dependencies, but this will be a breaking change.

@freekmurze
Copy link
Member

I've handled this myself. The latest versions now supports crawler v8.

@freekmurze freekmurze closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants