Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke flush before close_write in write_body_and_close. #33

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Invoke flush before close_write in write_body_and_close. #33

merged 1 commit into from
Apr 20, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Apr 20, 2024 •
edited
Loading

It does not appear guaranteed that close_write will flush the underlying IO buffers, so let's ensure it's flushed.

I encountered this problem when implementing async-http using native IO.

Types of Changes

  • Bug fix.

Contribution

@ioquatix
Invoke flush before close_write in write_body_and_close.
eb2941c 
It does not appear guaranteed that `close_write` will flush the underlying
IO buffers, so let's ensure it's flushed.
@ioquatix ioquatix merged commit 1ff458e into main Apr 20, 2024
42 of 44 checks passed
@ioquatix ioquatix deleted the write_and_close-flush branch April 20, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ioquatix