Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on Windows. #184

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Run tests on Windows. #184

wants to merge 3 commits into from

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Oct 13, 2022 •
edited
Loading

This is an experimental PR to see how badly Windows fails.

Types of Changes

  • New feature.

Testing

  • I added tests for my changes.
  • I tested my changes locally.
  • I tested my changes in staging.
  • I tested my changes in production.

@ioquatix ioquatix mentioned this pull request Dec 6, 2022
Open
@ioquatix
Copy link
Member Author

ioquatix commented Dec 6, 2022 

101 passed 1 failed 118 errored out of 220 total (257 assertions)

@ioquatix
Copy link
Member Author

ioquatix commented Dec 6, 2022

@larskanis not sure if you are interested to help on this, but the recent changes for UNIXSocket have made this easier.

@larskanis
Copy link

@ioquatix I made some small changes and it seems to work.

@ioquatix
Copy link
Member Author

ioquatix commented Dec 7, 2022 •
edited
Loading

@larskanis should we make IO on windows non-blocking by default where possible? It's already the default on Linux.

@ioquatix
Copy link
Member Author

ioquatix commented Dec 7, 2022

ruby/ruby#6874

@ioquatix ioquatix mentioned this pull request Dec 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioquatix @larskanis