Use margin instead of the padding for sections #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjula-sack
requested changes
Jun 3, 2023
There was a problem hiding this comment.
Update the following instead of updating all the files @YoshithaRathnayake,
Line 17184 in ba03a8b
Line 17185 in ba03a8b
|
How about now @anjula-sack ? |
anjula-sack
requested changes
Jun 3, 2023
|
@anjula-sack how about now? |
anjula-sack
requested changes
Jun 4, 2023
There was a problem hiding this comment.
@YoshithaRathnayake the only file that needs to be updated is assets/css/argon.css
|
How about now? @anjula-sack |
|
I have fixed some spacing issues also @anjula-sack |
|
@Piumal1999 can you review this too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #1485
Goals
Using margin instead of the padding for sections
Approach
Replace the margin for paddings
Screenshots
Before
After
Preview Link
https://pr-1582-sef-site.surge.sh/
Checklist
Related PRs
Learning