Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bugs of the footer in the mobile view #1331

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Fix the bugs of the footer in the mobile view #1331

wants to merge 20 commits into from

Conversation

YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake commented Oct 15, 2022 •
edited
Loading

Purpose

The purpose of this PR is to fix #1207

Goals

Fixing the bugs in the footer in the mobile view

Approach

Fixed the bugs in the footer in the mobile view

Screenshots

image

image

image

Preview Link

https://pr-1331-sef-site.surge.sh/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@YoshithaRathnayake
Copy link
Member Author

@anjula-sack how about now ?

@anjula-sack
Copy link
Member

Still, look the same on mobile?
image

@YoshithaRathnayake
Copy link
Member Author

YoshithaRathnayake commented Oct 15, 2022 •
edited
Loading

Still, look the same on mobile? image

So I couldn't found a design to solve that, therefore I put it like that. If it is bad, can you suggest a design for that resolution @anjula-sack

@YoshithaRathnayake
Copy link
Member Author

@anjula-sack how about now, I fixed it for some resolutions.

anjula-sack
anjula-sack requested changes Oct 22, 2022
View reviewed changes
assets/css/global-custom.css Outdated Show resolved Hide resolved
@YoshithaRathnayake
Add the EOL
ac5c52a 
Add the End of Line
@anjula-sack
Copy link
Member

can you fix the conflicts @YoshithaRathnayake ?

@YoshithaRathnayake
Copy link
Member Author

can you fix the conflicts @YoshithaRathnayake ?

Sure @anjula-sack can you give me little more time

@anjula-sack
Copy link
Member

can you fix the conflicts @YoshithaRathnayake ?

Sure @anjula-sack can you give me little more time

no worries. Take your time.

@YoshithaRathnayake
Copy link
Member Author

can you fix the conflicts @YoshithaRathnayake ?

Sure @anjula-sack can you give me little more time

no worries. Take your time.

Thanks @anjula-sack

@YoshithaRathnayake
Copy link
Member Author

Done @anjula-sack can you merge this now?

@YoshithaRathnayake YoshithaRathnayake requested review from Piumal1999 and anjula-sack and removed request for anjula-sack November 22, 2022 14:34
@anjula-sack
Copy link
Member

can you resolve the conflicts? @YoshithaRathnayake

@YoshithaRathnayake
Copy link
Member Author

can you resolve the conflicts? @YoshithaRathnayake

Done @anjula-sack resolved

@YoshithaRathnayake YoshithaRathnayake changed the title Fix the bugs in the footer in the mobile view Fix the bugs of the footer in the mobile view Dec 7, 2022
anjula-sack
anjula-sack requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you resolve the conflicts? @YoshithaRathnayake

@sef-global sef-global deleted a comment from anjula-sack Apr 19, 2023
@YoshithaRathnayake YoshithaRathnayake mentioned this pull request Apr 19, 2023
Closed
@YoshithaRathnayake
Copy link
Member Author

@anjula-sack can you check now?

@YoshithaRathnayake YoshithaRathnayake mentioned this pull request Apr 19, 2023
Closed
anjula-sack
anjula-sack requested changes Jul 6, 2024
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoshithaRathnayake Can you fix the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjula-sack anjula-sack anjula-sack requested changes

@Piumal1999 Piumal1999 Awaiting requested review from Piumal1999

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the bugs in the footer in the mobile view
2 participants
@YoshithaRathnayake @anjula-sack