Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use margin instead of the padding for sections #1485

Open
anjula-sack opened this issue Dec 26, 2022 · 8 comments · May be fixed by #1582
Open

Use margin instead of the padding for sections #1485

anjula-sack opened this issue Dec 26, 2022 · 8 comments · May be fixed by #1582
Assignees
@YoshithaRathnayake

Comments

@anjula-sack
Copy link
Member

Is your feature request related to a problem? Please describe.

  • Currently, we use padding for sections. which gives us unwanted spacing. It should be a margin instead of padding.

Describe the solution you'd like

  • Use margin instead of the padding for sections

Are you working on it?

  • No
@anjula-sack
Copy link
Member Author

@chavzzz can you work on this?

@chavzzz
Copy link

chavzzz commented Dec 26, 2022

@chavzzz can you work on this?

sure

chavzzz pushed a commit to chavzzz/sef-site that referenced this issue Jan 9, 2023
@chavvz
style: 💄 fix ui issues using margin instead of the padding for sections
152a08a 
sef-global#1485
@anjula-sack
Copy link
Member Author

@chavzzz What is the status of this?

@anjula-sack
Copy link
Member Author

@chavzzz Any updates?

@anjula-sack
Copy link
Member Author

@YoshithaRathnayake can you work on this?

@YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake can you work on this?

Sure @anjula-sack

@anjula-sack
Copy link
Member Author

@YoshithaRathnayake any updates on this?

@YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake any updates on this?

Oh sorry @anjula-sack I didn't see this issue. I'll update soon.

@YoshithaRathnayake YoshithaRathnayake linked a pull request Jun 2, 2023 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YoshithaRathnayake YoshithaRathnayake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use margin instead of the padding for sections YoshithaRathnayake/sef-site
3 participants
@anjula-sack @YoshithaRathnayake @chavzzz