[#17] Rename MultiSet to Bag

[joshlemer]

#17
Other changes:

• A bit more elaboration in the scaladocs explaining what a collection.Bag is.
• MultiMapTest /SortedMultiMapTest etc are renamed to MultiDictTest etc (must have forgotten to rename these when we went from MultiMap->MultiDict)

[exoego]

Could you consider adding aliases something like

@deprecated("Use Bag instead", "0.1.1")
type MultiSet = Bag

so existing users can notice deprecation and consider migration.

[joshlemer]

@exoego if I were to implement that with package objects (because types cannot be at top level) then I would run into conflicts of package objects with the canonical scala.collection scala.collection.immutable and scala.collection.mutable versions wouldn't I? I get compile errors when I try to implement the scala.collection.immutable package object here.

[joshlemer]

@exoego @julienrf any idea about the above comment? I don't know how it would be possible to implement these type aliases without conflicting with other package objects in the stdlib proper.

[julienrf]

I don’t see a nice solution to this problem. Would that work to define a deprecated class?

@deprecated("Use Bag instead", "0.1.1")
class MultiSet[A] extends Bag[A]

[joshlemer]

At that point, maybe just leave in the MultiSet implementation, as deprecated, and include the new Bag implementation separately?

[exoego]

You can define type aliases in package object.
So type alias looks top-level.

[exoego]

ah sorry, you already mentioned conflict in that approach

[exoego]

How about this change? joshlemer#1

[joshlemer]

@exoego that is the change that I tried to make but it resulted in compile errors, I'm pretty sure because of the duplicate package objects, but I'll merge that in for now and see how the CI handles it.

[SethTisue]

@joshlemer no activity in a while — should this stay open?

[joshlemer]

I ended up being blocked by #64 (and I think still would be) and so wasn't able to work on this any longer, but I still think Bag is a better name and worth switching to