Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glass/unset rwx access token in local tests #68

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

michaelglass
Copy link
Contributor

  • unset RWX_ACCESS_TOKEN when running tests locally
  • add a build command to captain for dev usage

@michaelglass michaelglass force-pushed the glass/unset-rwx-access-token-in-local-tests branch from 282d3b6 to 98d1f7c Compare July 10, 2023 13:52
@michaelglass michaelglass marked this pull request as ready for review July 10, 2023 14:02
@github-actions
Copy link

Bigtest for 98d1f7c (run)

Benchmarks:

  • RSpec: 11.73% overhead
    • RSpec time: 17.81 seconds
    • ABQ time: 19.9 seconds
  • RSpec parallel, 10 runs: max 16.28% overhead
    • min 7.07% overhead
    • standard deviation: 2.35%
  • Jest: 6.19% overhead
    • Jest time: 21.06 seconds
    • ABQ time: 22.364 seconds

Fuzz result sizes:

  • PASSED

@michaelglass michaelglass enabled auto-merge (squash) July 11, 2023 09:11
@github-actions
Copy link

Bigtest for a7dbf64 (run)

Benchmarks:

  • RSpec: 11.66% overhead
    • RSpec time: 17.84 seconds
    • ABQ time: 19.92 seconds
  • RSpec parallel, 10 runs: max 16.03% overhead
    • min 7.34% overhead
    • standard deviation: 3.40%
  • Jest: 6.42% overhead
    • Jest time: 21.047 seconds
    • ABQ time: 22.398 seconds

Fuzz result sizes:

  • PASSED

@michaelglass michaelglass merged commit 7a9ae4c into main Jul 11, 2023
17 checks passed
@michaelglass michaelglass deleted the glass/unset-rwx-access-token-in-local-tests branch July 11, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants