Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow better assertion for windows.rb #12

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

YO4
Copy link

@YO4 YO4 commented Sep 11, 2024

Edit: This PR was split to solve single problem. new PR is Fix for windows #13.

Follows Better assertion with less wait time #10,
wait_startup_message() and assert_screen() for windows.rb from vterm.rb

@YO4 YO4 force-pushed the follow_better_assertion branch 2 times, most recently from 6231dc2 to 2cc2f78 Compare September 13, 2024 12:09
@YO4 YO4 changed the title Follow better assertion and get working windows again Follow better assertion for windows.rb Sep 13, 2024
wait_startup_message() and assert_screen() similar to vterm.rb dc0a304 and 7a74aee
@YO4
Copy link
Author

YO4 commented Sep 25, 2024

The patch updated using current vterm.rb flagments.
Passed test in local environment in 12.9925985 seconds.

@YO4 YO4 marked this pull request as ready for review September 25, 2024 12:13
Copy link
Member

@tompng tompng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tompng tompng merged commit 3937fa3 into ruby:master Sep 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants