Add rvm-windows to installation doc #3250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Except for trailing white space. Spanish is good. |
…umentation' into feature-add_rvm_4_windows_to_documentation # Conflicts: # es/documentation/installation/index.md
marocchino
reviewed
May 20, 2024
marocchino
approved these changes
May 20, 2024
@vtamara trailing whitespaces removed |
yous
reviewed
May 21, 2024
Comment on lines
+341
to
+342
| ### RVM 4 Windows | ||
| {: #rvm-windows} |
There was a problem hiding this comment.
RVM 4 Windows should be added to TOC between "RVM" and "uru."
There was a problem hiding this comment.
My idea was to make it analogous to "rbenv for windows", which also does not have its own entry in TOC, but follows "rbenv". So does "RVM 4 Windows" follow "RVM".
|
Hey guys, for me it looks like, that many languages are even not maintained anymore, as no more reviews happend within one month. So, would you suggest me, to make a new PR only with Korean and English? Or is there a chance to get this PR ever merged without all languages reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new RVM 4 Windows to the list of Ruby version managers at the installation documentation.
Included languages are
bg de en es fr id it ja ko pl pt ru tr zh_cn