Kernel#eval when called with two arguments will use "(eval)" for __FI…LE__ and 1 for __LINE__ in the evaluated code. #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanCrg90
commented
Oct 16, 2021
| -> { | ||
| TCPSocket.send(@method, "192.0.2.1", 80, connect_timeout: 0) | ||
| }.should raise_error(Errno::ETIMEDOUT) | ||
| ruby_version_is "3.0" do |
There was a problem hiding this comment.
I think this block was missing on this commit 66edbec
…LE__ and 1 for __LINE__ in the evaluated code.
JuanCrg90
force-pushed
the
add_test_for_kernel_eval_with_two_arguments
branch
from
2391bbc
to
2a2efe6
Compare
JuanCrg90
commented
Oct 16, 2021
core/kernel/eval_spec.rb
Outdated
| @@ -182,6 +182,16 @@ class Object | |||
| end | |||
| end | |||
|
|
|||
| ruby_version_is "3.0" do | |||
| context 'with two arguments ' do | |||
| platform_is_not :windows do | |||
There was a problem hiding this comment.
This test fails on Windows with this error message 🤔
A child mspec-run process printed unexpected output on STDOUT: "[\"(eval)\", 1]\r\n" while running D:/a/spec/spec/core/kernel/eval_spec.rb
There was a problem hiding this comment.
For mspec -j one cannot print to STDOUT.
The p below is unnecessary and causing that issue, we can just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #823
Kernel#eval when called with two arguments will use
"(eval)"for
__FILE__and1for__LINE__in the evaluated code.[Bug #4352]