Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spec for ENV.except #826

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Conversation

lxxxvi
Copy link
Contributor

@lxxxvi lxxxvi commented Jan 8, 2021

Hello 👋

Here's my take on ENV.except from #823

ENV.except has been added, which returns a hash excluding the
given keys and their values. Feature #15822

Two notes:

  • Creating the spec for ENV.except using ../mspec/bin/mkspec -b core -c ENV didn't work, I created the file manually.
  • Testing .except without arguments is covered via it_behaves_like :env_to_hash, :except which is not super-obvious, I guess.

Please letme know if you like any changes etc.

Thanks, as always. 🙌

@eregon
Copy link
Member

eregon commented Jan 8, 2021

  • Testing .except without arguments is covered via it_behaves_like :env_to_hash, :except which is not super-obvious, I guess.

Could you add a comment about that above the it_behaves_like?

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lxxxvi
Copy link
Contributor Author

lxxxvi commented Jan 9, 2021

@eregon Thanks! I added the comment.

@eregon eregon merged commit e302f4f into ruby:master Jan 30, 2021
@lxxxvi lxxxvi deleted the add-spec-for-ENV-except branch January 31, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants