adds SyntaxError and warning spec for not same line heredoc #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
reviewed
Oct 8, 2020
| eval %{<<"HERE\n"\nHERE} | ||
| }.should complain(/here document identifier ends with a newline/) | ||
| end | ||
| end |
There was a problem hiding this comment.
Just wording issue. It's common to write just it warns or emits a warning here in the specs
There was a problem hiding this comment.
Do you mean add the message in heredoc string itself?
If so, check please. I've just added it.
There was a problem hiding this comment.
No-no. I meant the wording in the spec description - it 'prints a warning. It's not a problem and it's just a matter of taste .
andrykonchin
reviewed
Oct 8, 2020
language/heredoc_spec.rb
Outdated
| end | ||
|
|
||
| ruby_version_is ""..."2.7" do | ||
| it 'prints a warning if identifier is ending not on same line' do |
There was a problem hiding this comment.
I think it's missing "quoted identifier"
|
@andrykonchin thanks for review so far! I've just added fixes you mentioned |
andrykonchin
approved these changes
Oct 9, 2020
|
Thank you for the new specs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub task #745
Quoted here-document identifiers must end within the same line