Add specs for Range#reverse_each #1169
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| require_relative '../../spec_helper' | ||
|
|
||
| ruby_version_is "3.3" do | ||
| describe "Range#reverse_each" do | ||
| it "works efficiently for very long Ranges of Integers" do | ||
| (1..2**100).reverse_each.take(3).size.should == 3 | ||
| end | ||
|
|
||
| it "works for beginless Ranges of Integers" do | ||
| (..5).reverse_each.take(3).should == [5, 4, 3] | ||
| end | ||
|
|
||
| it "works for Ranges of Strings by converting the Range to an Array first" do | ||
| ("a".."z").reverse_each.take(3).should == ["z", "y", "x"] | ||
| end | ||
|
|
||
| it "raises a TypeError for endless Ranges of Integers" do | ||
| -> { | ||
| (1..).reverse_each.take(3) | ||
| }.should raise_error(TypeError, "can't iterate from NilClass") | ||
| end | ||
|
|
||
| it "raises a TypeError for endless Ranges of other objects" do | ||
| -> { | ||
| ("a"..).reverse_each.take(3) | ||
| }.should raise_error(TypeError, "can't iterate from NilClass") | ||
| end | ||
| end | ||
| end | ||
|
There was a problem hiding this comment. It makes sense to check the following files and have here the similar cases/structure:
There was a problem hiding this comment. All these tests are pretty specific for ranges. There is a spec in it "raises a TypeError beginless ranges" do
-> { (..2).each { |x| x } }.should raise_error(TypeError)
endThis specific case is not relevant for arrays, you can simply reverse iterate over it, there is no need there to construct a temporary array and there is no chance for it to become infinite. As for |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this test fails in case
#reverse_eachworks inefficiently.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is very much skirting the (MRI) implementation.
A Range is pretty much just a combination of a begin value, an end value, and an operation to get to the next value. In MRI 3.2 and below, there is no way to get to the previous value, so this code creates an array of
2**100elements, then takes the last three elements of this array. So in MRI 3.2, this will result in either aNoMemoryErroror an extremely long evaluation/timeout.MRI 3.3 added a specialization for this method when using Integer values, this code now boils down to something like
[2**100, (2**100).pred, (2**100).pred.pred]and finishes "instantly"This specialization currently only exists for Integer values, that's why there I've added a spec for the a-z-Range as well, to ensure other types still work.