Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RuntimeError in REXML::Parsers::BaseParser for valid feeds #199

Merged
merged 6 commits into from
Aug 17, 2024
Merged

Fix RuntimeError in REXML::Parsers::BaseParser for valid feeds #199

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
981b424
Fix RuntimeError for valid feeds
vikiv480 Aug 14, 2024
b5da207
PR feedback
vikiv480 Aug 15, 2024
6555c27
Add tests when default entities only
vikiv480 Aug 15, 2024
60632a5
Improve readability for `#entity`
vikiv480 Aug 16, 2024
b7e9378
Remove unnecessary `StringIO.new`
vikiv480 Aug 16, 2024
cd05526
Remove a needless empty line
kou Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/rexml/parsers/baseparser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,15 +505,13 @@ def pull_event
private :pull_event

def entity( reference, entities )
value = nil
vikiv480 marked this conversation as resolved.
Show resolved Hide resolved
value = entities[ reference ] if entities
if value
record_entity_expansion
else
value = DEFAULT_ENTITIES[ reference ]
value = value[2] if value
return unnormalize( value, entities ) if value
vikiv480 marked this conversation as resolved.
Show resolved Hide resolved
end
unnormalize( value, entities ) if value

nil
end

# Escapes all possible entities
Expand Down