Make "xml:" namespace a constant

ruby · Sep 27, 2024 · f531b70 · f531b70
1 parent f98d418
commit f531b70
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/rexml/parsers/baseparser.rb b/lib/rexml/parsers/baseparser.rb
@@ -140,6 +140,8 @@ class BaseParser
         "apos" => [/&apos;/, "&apos;", "'", /'/]
       }
 
+      XML_PREFIXED_NAMESPACE = "http://www.w3.org/XML/1998/namespace"
+
       module Private
         PEREFERENCE_PATTERN = /#{PEREFERENCE}/um
         TAG_PATTERN = /((?>#{QNAME_STR}))\s*/um
@@ -185,7 +187,7 @@ def stream=( source )
         @tags = []
         @stack = []
         @entities = []
-        @namespaces = {"xml" => "http://www.w3.org/XML/1998/namespace"}
+        @namespaces = {"xml" => XML_PREFIXED_NAMESPACE}
         @namespaces_restore_stack = []
       end
 
@@ -790,7 +792,7 @@ def parse_attributes(prefixes)
             @source.match(/\s*/um, true)
             if prefix == "xmlns"
               if local_part == "xml"
-                if value != "http://www.w3.org/XML/1998/namespace"
+                if value != XML_PREFIXED_NAMESPACE
                   msg = "The 'xml' prefix must not be bound to any other namespace "+
                     "(http://www.w3.org/TR/REC-xml-names/#ns-decl)"
                   raise REXML::ParseException.new( msg, @source, self )