New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ToRdoc#accept_table #1184

Open

tompng wants to merge 1 commit into ruby:master from tompng:fix_to_rdoc_table

Member

tompng commented Sep 30, 2024

Document of Integer#ceil in ruby 3.4.0dev have table. RDoc fails to show tables in text format.

Fix ri Integer#ceil

# ruby -v
ruby 3.4.0dev (2024-09-27T17:45:22Z master 027ef60500) +PRISM [x86_64-linux]
# ri Integer#ceil
/opt/ruby/lib/ruby/3.4.0+0/rdoc/markup/to_rdoc.rb:265:in 'Array#zip': wrong argument type NilClass (must respond to :each) (TypeError)

    @res << header.zip(widths, aligns) do |h, w, a|

Fix IRB crash

irb(main):001> 1.[TAB][TAB]
/opt/ruby/lib/ruby/3.4.0+0/rdoc/markup/to_rdoc.rb:265:in 'Array#zip': wrong argument type NilClass (must respond to :each) (TypeError)


          Fix ToRdoc#accept_table

3c17d05

Member

colby-swandale commented Oct 1, 2024

Could we separate the various fixes into their own commits, it would make reviewing each fix much easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet