Update Symbol #1930
Update Symbol #1930
Conversation
core/string.rbs
Outdated
|
|
||
| interface _MatchAgainst[O, T] |
There was a problem hiding this comment.
It didnt make much sense to have an O field here, as it's only ever being matched against Strings, so I've removed the field. However, it is a breaking change, so we might want to hold off on this
There was a problem hiding this comment.
Changing from O = self to String loses type narrowing.
Having a generic #=~ (with both LHS and RHS type variables) is also fine for #1638.
There was a problem hiding this comment.
Resolved by reverting this
| @@ -469,6 +469,4 @@ class Symbol | |||
| | (:ascii | :lithuanian | :turkic) -> Symbol | |||
| | (:lithuanian, :turkic) -> Symbol | |||
| | (:turkic, :lithuanian) -> Symbol | |||
|
|
|||
| def clone: (?freeze: true?) -> self | |||
There was a problem hiding this comment.
Not actually defined in Symbol
sampersand
force-pushed
the
swesterman/24-07-12/symbol
branch
2 times, most recently
from
a2fc0dd
to
f953dd2
Compare
| @@ -176,7 +174,7 @@ class Symbol | |||
| # variables; see String#=~. | |||
| # | |||
| def =~: (Regexp regex) -> Integer? | |||
| | [T] (String::_MatchAgainst[self, T] object) -> T | |||
| | [T] (String::_MatchAgainst[String, T] object) -> T | |||
There was a problem hiding this comment.
[Optional] Wondering if you can add a test to confirm the _MatchAgains generic interface works correctly with Steep. (in test/typecheck/_MatchAgainst or somewhere.)
There was a problem hiding this comment.
Do we have any of these as examples to base it off of?
soutaro
force-pushed
the
swesterman/24-07-12/symbol
branch
from
beac527
to
6d56108
Compare
soutaro
force-pushed
the
swesterman/24-07-12/symbol
branch
from
6d56108
to
97e5fbc
Compare
|
@sampersand Added a few tests at 97e5fbc. |
This pr updates
Symbol.There wasn't actually a ton to do; it was mostly marking things as aliases, and copying signatures over from
String(eg forSymbol#[]).