Proposal: Support auto extending module #1503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Sep 5, 2023
Comment on lines
+786
to
+787
| Module having "autoextend:..." annotation is considered as an auto extending module. | ||
| When such auto extending modules are included, the including class will be extended by annotated modules. |
There was a problem hiding this comment.
We need to find a better name for the "auto extending module" and its annotation.
In Ruby language, developers need to use both "include" and "extend" to implement mix-in having instance methods and class methods. The auto extending module is a well-known technique to realize it (ex. `ActiveSupport::Concern`, "extend" call in `included` block, and so on). This supports the auto extending modules via modules having "autoextend:..." annotation. The `RBS::DefinitionBuilder` searches the extended modules from the annotations of the included modules.
tk0miya
force-pushed
the
support_auto_extending_modules
branch
from
5cbbf15
to
421fd6d
Compare
tk0miya
commented
Sep 5, 2023
soutaro
reviewed
Sep 28, 2023
soutaro
reviewed
Sep 28, 2023
soutaro
reviewed
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby language, developers need to use both "include" and "extend" to implement mix-in having instance methods and class methods. The auto extending module is a well-known technique to realize it (ex.
ActiveSupport::Concern, "extend" call inincludedblock, and so on).This supports the auto extending modules via modules having "autoextend:..." annotation. The
RBS::DefinitionBuildersearches the extended modules from the annotations of the included modules.