Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clear that scope is ignored purposely in FileTask.scope_name #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rickhull
Copy link
Contributor

@rickhull rickhull commented Nov 7, 2017

I'm not 100% certain on whether this change is desirable or self-evidently so. But I definitely had to do a double-take when I looked at the method definition and saw that only the last argument was even considered. The existing comments somewhat explain it. I think the leading underscore on _scope makes the code more self-evident.

Note, this PR was resubmitted from a non-master branch of my fork.

@rickhull rickhull changed the title make clear that scope is ignored purposely make clear that scope is ignored purposely in FileTask.scope_name Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant