Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rack RBS to 2.2.4 #215

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Update Rack RBS to 2.2.4 #215

merged 3 commits into from
Oct 4, 2022

Conversation

ParadoxV5
Copy link
Contributor

@ParadoxV5 ParadoxV5 commented Sep 29, 2022

This PR updates rack RBS to Rack 2.2.4 by incorporating diffs between 2.2.2 and 2.2.4.

This PR directly git mv the 2.2.2 RBS and _test files to the 2.2.4 directory. Because Rack’s RBS has untyped entries and potentially-incorrect types (#210), I determined it is not suitable for production (yet?) and did not keep the 2.2.2 directory. This PR does not address the aforementioned content issues.

I ran steep check using Bundler (to constraint Rack’s version to 2.2.4, Gemfile/.lock not checked in) and No type error detected. 🧋

@pocke
Copy link
Member

pocke commented Oct 3, 2022

Could you move the directory from rack/2.2.2/ to rack/2.2.4/?

Basically, the version should be MAJOR.MINOR, but without a patch version. Patch versions don't have interface changes in most cases, so it is not necessary that we make other directories for each patch version.

https://github.com/ruby/gem_rbs_collection/blob/dc7059ea0cdf67f486ca9cea2b01d53f04724652/docs/CONTRIBUTING.md#generate-a-boilerplate

@ParadoxV5
Copy link
Contributor Author

Could you move the directory from rack/2.2.2/ to rack/2.2.4/?

Aren’t they already moved, @pocke? Or did you mean to move to rack/2.2?

Patch versions don't have interface changes in most cases

That is correct. IIRC, there were no method changes between 2.2.2 and 2.2.4, although there were minor differences in the exposed internals that one could (but unlikely would) use.

@pocke
Copy link
Member

pocke commented Oct 4, 2022

Aren’t they already moved, @pocke? Or did you mean to move to rack/2.2?

Ah, sorry. I meant moving to rack/2.2 🙈 Could you rename the directory?

`@pocke` said in PR that “the version should be `MAJOR.MINOR`, but without a patch version.”

Co-Authored-By: Masataka Pocke Kuwabara <[email protected]>
@ParadoxV5
Copy link
Contributor Author

👌

Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pocke pocke enabled auto-merge October 4, 2022 04:20
@pocke pocke merged commit c77f8fc into ruby:main Oct 4, 2022
@ParadoxV5 ParadoxV5 deleted the rack224 branch October 4, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants