Include **/factories.rb in the inspection target

[r7kamura]

According to the factory_bot documentation, the default FactoryBot.definition_file_paths also includes factories.rb.

The load order is controlled by the FactoryBot.definition_file_paths attribute. The default load order is:

1. factories.rb
2. test/factories.rb
3. test/factories/**/*.rb
4. spec/factories.rb
5. spec/factories/**/*.rb

• https://github.com/thoughtbot/factory_bot/blob/cf3f21fcbbccbc40849c74a84eeb0bb0bd6c7606/docs/src/ref/find_definitions.md?plain=1#L9-L13

Therefore, it would be reasonable to include this file in the inspection target.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

• Added the new cop to config/default.yml.
• The cop is configured as Enabled: pending in config/default.yml.
• The cop documents examples of good and bad code.
• The tests assert both that bad code is reported and that good code is not reported.
• Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

• Set VersionChanged: "<<next>>" in config/default.yml.

[pirj]

I’m uncertain if it’s deliberate or not, but they would also load from factories/**/*.rb

Yet another doc https://github.com/thoughtbot/factory_bot/blob/cf3f21fcbbccbc40849c74a84eeb0bb0bd6c7606/docs/src/defining/file-paths.md?plain=1#L7 yhat doesn’t mention this consistently.

[pirj]

But would we also analyze eg app/presenters/factories.rb?

[r7kamura]

Yes, but I think this is a risk we should accept when we decide to put **/ at the beginning of Include. It is also inconsistent that other Includes support it, but not only here.
Since it is rare for a constant to be defined in the plural form, I believe that this is rarely a problem in practice.

[ydah]

I understand that factory_bot defaults to **/factories.rb as the definition file path. However, I doubt that it should be the default for rubocop-factory_bot. Because I am concerned about the increased risk of false positives, as also #104 (comment).

Also, even if some users wanted to fix this, I felt it was not necessary to include it in the default because it could be avoided by simply adding the target path to FactoryBot: Include: .